feat: Redesign env confirmation dialog with improved layout#186
Open
turbolego wants to merge 7 commits into
Open
feat: Redesign env confirmation dialog with improved layout#186turbolego wants to merge 7 commits into
turbolego wants to merge 7 commits into
Conversation
added 7 commits
May 16, 2026 07:36
…ollable details - Create custom WebView dialog instead of native modal - Layout: Message on left, env details on right (scrollable) - Env details section only scrolls, dialog fits within screen height - Wider popup reduces vertical scrolling and improves readability - Add confirmEnvAction() method for environment-specific dialogs - Update env-service to use new dialog for env selection confirmation
…yout - Message now displayed at top (row 1) - Env details section below (row 2, scrollable) - Buttons remain at bottom - More intuitive vertical flow for sequential information reading
- Create showFilePermissionDialog() for scrollable file path display - Add confirmFilePermissionAction() helper method - Update tools.ts to use new file permission dialog - File path no longer cut off - scrollable section for full visibility - Consistent styling with env confirmation dialog - Supports Yes/No and Don't Ask Again options
- Convert showYesNoDialog() to use custom WebView instead of native modal - Convert showOkDialog() to use custom WebView instead of native modal - Update confirmAction() to use showEnvConfirmationDialog() for consistency - All env popups now display full details without text truncation - Fixes env add, delete, view, export confirmations
- Update showYesYesdontaskNoDialog() to use custom WebView format - Update showYesNoNodontAskDialog() to use custom WebView format - Update showUserChoiceDialog() to use custom WebView format - All dialogs now support scrollable message areas - Fixes env startup confirmation (architect.ts) - Fixes installation confirmations - Ensures consistent UI across all confirmation dialogs
- Fix \\n to \n in showYesYesdontaskNoDialog() - Fix \\n to \n in showYesNoNodontAskDialog() - Fix \\n to \n in showUserChoiceDialog() - Ensures newline characters are properly converted to HTML <br> tags - Fixes text truncation issues in all confirmation dialogs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves the environment selection confirmation dialog in llama-vscode.
Before/After:
What's Changed
Files Modified
src/utils.ts: AddedshowEnvConfirmationDialog()andconfirmEnvAction()methodssrc/services/env-service.ts: Updated to use new env-specific confirmation dialogUI Improvements